Bug#813491: s390-tools: packaging updates

[Dimitri John Ledkov]

Package: s390-tools
Severity: normal
Tags: patch

Dear Maintainer,

I've modernised packaging a bit, and fix a bunch of lintian tags.

I also made a patch to prevent FTBFS, when toolchain has PIE enabled by
default.

Please consider applying the below patch.

Regards,

Dimitri.

[Philipp Kern]

Post by Dimitri John Ledkov
I've modernised packaging a bit, and fix a bunch of lintian tags.
I also made a patch to prevent FTBFS, when toolchain has PIE enabled by
default.
Please consider applying the below patch.

Please use your connections with IBM to apply the spelling fixes
upstream. Every divergence we keep on the Debian side needs to be
justified as they are a pain to rebase on a new release.

The same is obviously true of the error-manpages diff as well, but that
was already there. I'd appreciate if IBM could look through the patches
if anything could be done to get them upstream so that we can carry
less of a delta.

The other changes are fine to me if there's no change to the actual
package output except descriptions and build output. Did you test the
resulting package on an actual s390 machine on *Debian*?

I'm a bit surprised about the explicit addition of the hardening flags,
given that none of the binaries is suid nor a network daemon. So we
could just follow the distro-default here. But I'm not too bothered by
it.

Kind regards and thanks
Philipp Kern

[Dimitri John Ledkov]

Post by Philipp Kern

Post by Dimitri John Ledkov
I've modernised packaging a bit, and fix a bunch of lintian tags.
I also made a patch to prevent FTBFS, when toolchain has PIE enabled by
default.
Please consider applying the below patch.

Please use your connections with IBM to apply the spelling fixes
upstream. Every divergence we keep on the Debian side needs to be
justified as they are a pain to rebase on a new release.

OK.

Post by Philipp Kern
The same is obviously true of the error-manpages diff as well, but that
was already there. I'd appreciate if IBM could look through the patches
if anything could be done to get them upstream so that we can carry
less of a delta.

OK.

Post by Philipp Kern
The other changes are fine to me if there's no change to the actual
package output except descriptions and build output. Did you test the
resulting package on an actual s390 machine on *Debian*?

I have not, I shall dedicate one of my z/VMs for Debian testing actually.

Post by Philipp Kern
I'm a bit surprised about the explicit addition of the hardening flags,
given that none of the binaries is suid nor a network daemon. So we
could just follow the distro-default here. But I'm not too bothered by
it.

True. Well, PIE is enabled in the tool-chain by default on Ubuntu, and
that does break zipl (ie. it needs it disabled). Thus actually apart
from "because I can", I'm not sure all hardening flags are actually
justified here.