Build failure of postgres-xc

[Michael Meskes]

Hi,

I just noticed that Postgres-XC doesn't build on S390. However, Postgresql,
which Postgres-XC is based on, builds just fine. Could anyone of you give me a
pointer where I should look or tell upstream to look? I hope you've seen
similar problems before.

The log is here: https://buildd.debian.org/status/fetch.php?pkg=postgres-xc&arch=s390&ver=1.1-1&stamp=1378820737

Thanks.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

[Bastian Blank]

Post by Michael Meskes
The log is here: https://buildd.debian.org/status/fetch.php?pkg=postgres-xc&arch=s390&ver=1.1-1&stamp=1378820737

It uses -fpic instead of -fPIC.

Bastian

[Michael Meskes]

Post by Bastian Blank

Post by Michael Meskes
The log is here: https://buildd.debian.org/status/fetch.php?pkg=postgres-xc&arch=s390&ver=1.1-1&stamp=1378820737

It uses -fpic instead of -fPIC.

It appears to me that it uses both at the same time. Now I have no idea what
effect that has, but postgresql which XC is based on does the same and it
compiles cleanly on s390.

I was expecting the problem to be the gtm module, but that seems to be build with -fPIC, too.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

[Bastian Blank]

Post by Michael Meskes

Post by Bastian Blank

Post by Michael Meskes
The log is here: https://buildd.debian.org/status/fetch.php?pkg=postgres-xc&arch=s390&ver=1.1-1&stamp=1378820737

It uses -fpic instead of -fPIC.

It appears to me that it uses both at the same time. Now I have no idea what
effect that has, but postgresql which XC is based on does the same and it
compiles cleanly on s390.

Using both should lead to the behaviour of -fPIC if I remember
correctly. However this may differ per architecture.

Does postgresql uses the same compiler options? Was it build with the same
toolchain? Did you alreeady try to build it on the developer machine?

The usage of -pie looks weird. A position independant executable is
only half a shared library.

Sorry, I can't really investigate while traveling.

Bastian

[Bastian Blank]

Post by Bastian Blank
Does postgresql uses the same compiler options?

It does not:
New are: -lpthread and -Wl,-z,now
Removed are the krb5 support.

Post by Bastian Blank
Was it build with the same
toolchain?

Looks like. However this does not count for differences in size of the
object files.

Bastian

[Bastian Blank]

Post by Michael Meskes

Post by Bastian Blank

Post by Michael Meskes
The log is here: https://buildd.debian.org/status/fetch.php?pkg=postgres-xc&arch=s390&ver=1.1-1&stamp=1378820737

It uses -fpic instead of -fPIC.

It appears to me that it uses both at the same time. Now I have no idea what
effect that has, but postgresql which XC is based on does the same and it
compiles cleanly on s390.

Okay. The reason is the stray -fpic. On s390* this restricts the
shared lib to 2^11-1 bytes. And the last setting wins.

Bastian

[Michael Meskes]

Post by Bastian Blank
Okay. The reason is the stray -fpic. On s390* this restricts the
shared lib to 2^11-1 bytes. And the last setting wins.

Got it. I changed the Makefile to not use -fpic on s390* and now it seems to
compile cleanly. Let's see if the autobuilders agree. :)

Thanks a lot Bastian.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

[Bastian Blank]

Post by Michael Meskes

Post by Bastian Blank
Okay. The reason is the stray -fpic. On s390* this restricts the
shared lib to 2^11-1 bytes. And the last setting wins.

Got it. I changed the Makefile to not use -fpic on s390* and now it seems to
compile cleanly. Let's see if the autobuilders agree. :)

You _never_ want to use -fpic, regardless of the architecture.

Bastian

[Michael Meskes]

Post by Bastian Blank
You _never_ want to use -fpic, regardless of the architecture.

Explain that a bit, will you?

I'm getting mixed feedback from upstream and like to understand what's going on here.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL