Bug#1080317: s390-tools: FTBFS: passing argument 2 of 'EVP_PKEY_meth_set_copy' from incompatible pointer type [-Wincompatible-pointer-types]

[Petter Reinholdtsen]

Package: s390-tools
Version: 2.16.0-2.1
Severity: serious

With gcc 14, the s390-tools package do not build:

utilities.c: In function 'create_json_web_signature':
utilities.c:535:33: warning: 'EC_KEY_get0_group' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
535 | EC_KEY_get0_group(EVP_PKEY_get0_EC_KEY(pkey))));
| ^~~~~~~~~~~~~~~~~
In file included from /usr/include/openssl/x509.h:33,
from /usr/include/openssl/pem.h:23,
from utilities.c:17:
/usr/include/openssl/ec.h:1053:39: note: declared here
1053 | OSSL_DEPRECATEDIN_3_0 const EC_GROUP *EC_KEY_get0_group(const EC_KEY *key);
| ^~~~~~~~~~~~~~~~~
utilities.c:535:33: warning: 'EVP_PKEY_get0_EC_KEY' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
535 | EC_KEY_get0_group(EVP_PKEY_get0_EC_KEY(pkey))));
| ^~~~~~~~~~~~~~~~~
In file included from utilities.c:16:
/usr/include/openssl/evp.h:1382:25: note: declared here
1382 | const struct ec_key_st *EVP_PKEY_get0_EC_KEY(const EVP_PKEY *pkey);
| ^~~~~~~~~~~~~~~~~~~~
utilities.c: In function 'verify_json_web_signature':
utilities.c:673:17: warning: 'EC_KEY_get0_group' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
673 | curve_nid = EC_GROUP_get_curve_name(EC_KEY_get0_group(
| ^~~~~~~~~
/usr/include/openssl/ec.h:1053:39: note: declared here
1053 | OSSL_DEPRECATEDIN_3_0 const EC_GROUP *EC_KEY_get0_group(const EC_KEY *key);
| ^~~~~~~~~~~~~~~~~
utilities.c:674:49: warning: 'EVP_PKEY_get0_EC_KEY' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
674 | EVP_PKEY_get0_EC_KEY(pkey)));
| ^~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/evp.h:1382:25: note: declared here
1382 | const struct ec_key_st *EVP_PKEY_get0_EC_KEY(const EVP_PKEY *pkey);
| ^~~~~~~~~~~~~~~~~~~~
utilities.c: In function 'ecc_pub_key_as_pkey':
utilities.c:2080:9: warning: 'EC_KEY_new' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2080 | ec = EC_KEY_new();
| ^~
/usr/include/openssl/ec.h:987:31: note: declared here
987 | OSSL_DEPRECATEDIN_3_0 EC_KEY *EC_KEY_new(void);
| ^~~~~~~~~~
utilities.c:2086:9: warning: 'EC_KEY_set_group' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2086 | rc = EC_KEY_set_group(ec, group);
| ^~
/usr/include/openssl/ec.h:1061:27: note: declared here
1061 | OSSL_DEPRECATEDIN_3_0 int EC_KEY_set_group(EC_KEY *key, const EC_GROUP *group);
| ^~~~~~~~~~~~~~~~
utilities.c:2092:9: warning: 'EC_KEY_set_public_key_affine_coordinates' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2092 | rc = EC_KEY_set_public_key_affine_coordinates(ec, bn_x, bn_y);
| ^~
/usr/include/openssl/ec.h:1141:27: note: declared here
1141 | OSSL_DEPRECATEDIN_3_0 int EC_KEY_set_public_key_affine_coordinates(EC_KEY *key,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
utilities.c:2104:9: warning: 'EVP_PKEY_assign' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2104 | rc = EVP_PKEY_assign_EC_KEY(*pkey, ec);
| ^~
/usr/include/openssl/evp.h:1338:5: note: declared here
1338 | int EVP_PKEY_assign(EVP_PKEY *pkey, int type, void *key);
| ^~~~~~~~~~~~~~~
utilities.c: In function 'rsa_pub_key_as_pkey':
utilities.c:2164:9: warning: 'RSA_new' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2164 | rsa = RSA_new();
| ^~~
In file included from /usr/include/openssl/x509.h:36:
/usr/include/openssl/rsa.h:212:28: note: declared here
212 | OSSL_DEPRECATEDIN_3_0 RSA *RSA_new(void);
| ^~~~~~~
utilities.c:2170:9: warning: 'RSA_set0_key' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2170 | rc = RSA_set0_key(rsa, bn_modulus, bn_pub_exp, NULL);
| ^~
/usr/include/openssl/rsa.h:218:27: note: declared here
218 | OSSL_DEPRECATEDIN_3_0 int RSA_set0_key(RSA *r, BIGNUM *n, BIGNUM *e, BIGNUM *d);
| ^~~~~~~~~~~~
utilities.c:2182:9: warning: 'EVP_PKEY_assign' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2182 | rc = EVP_PKEY_assign(*pkey, pkey_type, rsa);
| ^~
/usr/include/openssl/evp.h:1338:5: note: declared here
1338 | int EVP_PKEY_assign(EVP_PKEY *pkey, int type, void *key);
| ^~~~~~~~~~~~~~~
utilities.c: In function 'sk_pkey_meth_sign':
utilities.c:2760:17: warning: 'EVP_PKEY_get0_RSA' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2760 | max_saltlen = (EVP_PKEY_get0_RSA(pkey) != NULL ?
| ^~~~~~~~~~~
/usr/include/openssl/evp.h:1356:22: note: declared here
1356 | const struct rsa_st *EVP_PKEY_get0_RSA(const EVP_PKEY *pkey);
| ^~~~~~~~~~~~~~~~~
utilities.c:2761:41: warning: 'RSA_bits' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2761 | RSA_bits(EVP_PKEY_get0_RSA(pkey)) :
| ^~~~~~~~
/usr/include/openssl/rsa.h:214:27: note: declared here
214 | OSSL_DEPRECATEDIN_3_0 int RSA_bits(const RSA *rsa);
| ^~~~~~~~
utilities.c:2761:41: warning: 'EVP_PKEY_get0_RSA' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2761 | RSA_bits(EVP_PKEY_get0_RSA(pkey)) :
| ^~~~~~~~
/usr/include/openssl/evp.h:1356:22: note: declared here
1356 | const struct rsa_st *EVP_PKEY_get0_RSA(const EVP_PKEY *pkey);
| ^~~~~~~~~~~~~~~~~
utilities.c: In function 'setup_secure_key_pkey_method':
utilities.c:2961:9: warning: 'EVP_PKEY_meth_new' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2961 | pkey_meth = EVP_PKEY_meth_new(pkey_id, 0);
| ^~~~~~~~~
/usr/include/openssl/evp.h:1754:40: note: declared here
1754 | OSSL_DEPRECATEDIN_3_0 EVP_PKEY_METHOD *EVP_PKEY_meth_new(int id, int flags);
| ^~~~~~~~~~~~~~~~~
utilities.c:2965:9: warning: 'EVP_PKEY_meth_set_init' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2965 | EVP_PKEY_meth_set_init(pkey_meth, sk_pkey_meth_init);
| ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/evp.h:2010:28: note: declared here
2010 | OSSL_DEPRECATEDIN_3_0 void EVP_PKEY_meth_set_init(EVP_PKEY_METHOD *pmeth,
| ^~~~~~~~~~~~~~~~~~~~~~
utilities.c:2966:9: warning: 'EVP_PKEY_meth_set_cleanup' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2966 | EVP_PKEY_meth_set_cleanup(pkey_meth, sk_pkey_meth_cleanup);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/evp.h:2015:28: note: declared here
2015 | OSSL_DEPRECATEDIN_3_0 void EVP_PKEY_meth_set_cleanup
| ^~~~~~~~~~~~~~~~~~~~~~~~~
utilities.c:2967:9: warning: 'EVP_PKEY_meth_set_copy' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2967 | EVP_PKEY_meth_set_copy(pkey_meth, sk_pkey_meth_copy);
| ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/evp.h:2012:28: note: declared here
2012 | OSSL_DEPRECATEDIN_3_0 void EVP_PKEY_meth_set_copy
| ^~~~~~~~~~~~~~~~~~~~~~
utilities.c:2967:43: error: passing argument 2 of 'EVP_PKEY_meth_set_copy' from incompatible pointer type [-Wincompatible-pointer-types]
2967 | EVP_PKEY_meth_set_copy(pkey_meth, sk_pkey_meth_copy);
| ^~~~~~~~~~~~~~~~~
| |
| int (*)(EVP_PKEY_CTX *, EVP_PKEY_CTX *) {aka int (*)(struct evp_pkey_ctx_st *, struct evp_pkey_ctx_st *)}
/usr/include/openssl/evp.h:2013:36: note: expected 'int (*)(EVP_PKEY_CTX *, const EVP_PKEY_CTX *)' {aka 'int (*)(struct evp_pkey_ctx_st *, const struct evp_pkey_ctx_st *)'} but argument is of type 'int (*)(EVP_PKEY_CTX *, EVP_PKEY_CTX *)' {aka 'int (*)(struct evp_pkey_ctx_st *, struct evp_pkey_ctx_st *)'}
2013 | (EVP_PKEY_METHOD *pmeth, int (*copy) (EVP_PKEY_CTX *dst,
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
2014 | const EVP_PKEY_CTX *src));
| ~~~~~~~~~~~~~~~~~~~~~~~~
utilities.c:2968:9: warning: 'EVP_PKEY_meth_set_ctrl' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2968 | EVP_PKEY_meth_set_ctrl(pkey_meth, sk_pkey_meth_ctrl, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/evp.h:2057:28: note: declared here
2057 | OSSL_DEPRECATEDIN_3_0 void EVP_PKEY_meth_set_ctrl
| ^~~~~~~~~~~~~~~~~~~~~~
utilities.c:2969:9: warning: 'EVP_PKEY_meth_set_sign' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2969 | EVP_PKEY_meth_set_sign(pkey_meth, NULL, sk_pkey_meth_sign);
| ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/evp.h:2023:28: note: declared here
2023 | OSSL_DEPRECATEDIN_3_0 void EVP_PKEY_meth_set_sign
| ^~~~~~~~~~~~~~~~~~~~~~
utilities.c:2971:9: warning: 'EVP_PKEY_meth_add0' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2971 | if (EVP_PKEY_meth_add0(pkey_meth) != 1)
| ^~
/usr/include/openssl/evp.h:1760:27: note: declared here
1760 | OSSL_DEPRECATEDIN_3_0 int EVP_PKEY_meth_add0(const EVP_PKEY_METHOD *pmeth);
| ^~~~~~~~~~~~~~~~~~
utilities.c: In function 'cleanup_secure_key_pkey_method':
utilities.c:2996:9: warning: 'EVP_PKEY_meth_find' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
2996 | pkey_meth = EVP_PKEY_meth_find(pkey_id);
| ^~~~~~~~~
/usr/include/openssl/evp.h:1753:46: note: declared here
1753 | OSSL_DEPRECATEDIN_3_0 const EVP_PKEY_METHOD *EVP_PKEY_meth_find(int type);
| ^~~~~~~~~~~~~~~~~~
utilities.c:3000:9: warning: 'EVP_PKEY_meth_remove' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
3000 | if (EVP_PKEY_meth_remove(pkey_meth) != 1)
| ^~
/usr/include/openssl/evp.h:1761:27: note: declared here
1761 | OSSL_DEPRECATEDIN_3_0 int EVP_PKEY_meth_remove(const EVP_PKEY_METHOD *pmeth);
| ^~~~~~~~~~~~~~~~~~~~
utilities.c:3003:9: warning: 'EVP_PKEY_meth_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
3003 | EVP_PKEY_meth_free((EVP_PKEY_METHOD *)pkey_meth);
| ^~~~~~~~~~~~~~~~~~
/usr/include/openssl/evp.h:1759:28: note: declared here
1759 | OSSL_DEPRECATEDIN_3_0 void EVP_PKEY_meth_free(EVP_PKEY_METHOD *pmeth);
| ^~~~~~~~~~~~~~~~~~
make[1]: *** [../common.mak:253: utilities.o] Error 1
make: *** [Makefile:48: libekmfweb] Error 2

[Andreas Beckmann]

I've made an NMU to DELAYED/3 fixing the two open RC bugs.

s390-tools is orphaned (#1084987), so you should rather do a QA upload
(and update the maintainer to QA) instead of a NMU.


Andreas

[Debian Bug Tracking System]

Your message dated Sat, 26 Oct 2024 19:21:47 +0000
with message-id <E1t4mM7-00CTf0-***@fasolo.debian.org>
and subject line Bug#1080317: fixed in s390-tools 2.16.0-2.2
has caused the Debian Bug report #1080317,
regarding s390-tools: FTBFS: passing argument 2 of 'EVP_PKEY_meth_set_copy' from incompatible pointer type [-Wincompatible-pointer-types]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ***@bugs.debian.org
immediately.)